johann/cpu_features
1
0
Fork 0
mirror of https://github.com/google/cpu_features.git synced 2025-04-27 15:12:30 +02:00
Code Issues Releases Wiki Activity

Merge pull request #374 from google/fix_overwrite_backslash_zero_in_list_cpu_features

Browse Source 
Fix allocator bump in printf string allocation
This commit is contained in:
Guillaume Chatelet 2024-12-17 14:26:09 +01:00 committed by GitHub
commit 65b952aff1
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 5 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
src/utils/list_cpu_features.c
View File

@ -148,7 +148,11 @@ static Node* CreatePrintfString(const char* format, ...) {
const int written = vsnprintf(ptr, gBumpAllocator.size, format, arglist);
va_end(arglist);
if (written < 0 || written >= (int)gBumpAllocator.size) internal_error();
return CreateConstantString((char*)BA_Bump(written));
// `vsnprintf` does not set `\0` when no characters are to be written.
if (written == 0) *ptr = '\0';
// `vsnprintf` returns the number of printed characters excluding `\0`.
const int null_terminated_written = written + 1;
return CreateConstantString((char*)BA_Bump(null_terminated_written));
}
// Adds a string node.