mirror of
https://github.com/google/cpu_features.git
synced 2025-04-28 07:23:37 +02:00
bdb36d9489
Visual C++ reported a number of warnings: ..\src\filesystem.c(27): warning C4996: '_open': This function or variable may be unsafe. Consider using _sopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. ..\src\filesystem.c(34): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data ..\src\string_view.c(25): warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data ..\src\string_view.c(41): warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data ..\src\utils\list_cpu_features.c(151): warning C4090: 'function': different 'const' qualifiers ..\src\cpuinfo_x86.c(67): warning C4244: 'return': conversion from 'unsigned __int64' to 'uint32_t', possible loss of data ..\test\filesystem_for_testing.cc(48): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data ..\test\filesystem_for_testing.cc(57): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data ..\test\bit_utils_test.cc(26): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data ..\test\bit_utils_test.cc(32): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data ..\test\bit_utils_test.cc(37): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data Most of them, with the exception of _open() -> _sopen_s() are about questionable implicit casts. Fixing the types and adding explicit casts to explicitly mark the intention (and silence the warnings in the process)
54 lines
1.5 KiB
C++
54 lines
1.5 KiB
C++
// Copyright 2017 Google Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
#include "internal/bit_utils.h"
|
|
|
|
#include "gtest/gtest.h"
|
|
|
|
namespace cpu_features {
|
|
namespace {
|
|
|
|
TEST(UtilsTest, IsBitSet) {
|
|
for (size_t bit_set = 0; bit_set < 32; ++bit_set) {
|
|
const uint32_t value = 1UL << bit_set;
|
|
for (uint32_t i = 0; i < 32; ++i) {
|
|
EXPECT_EQ(IsBitSet(value, i), i == bit_set);
|
|
}
|
|
}
|
|
|
|
// testing 0, all bits should be 0.
|
|
for (uint32_t i = 0; i < 32; ++i) {
|
|
EXPECT_FALSE(IsBitSet(0, i));
|
|
}
|
|
|
|
// testing ~0, all bits should be 1.
|
|
for (uint32_t i = 0; i < 32; ++i) {
|
|
EXPECT_TRUE(IsBitSet(-1, i));
|
|
}
|
|
}
|
|
|
|
TEST(UtilsTest, ExtractBitRange) {
|
|
// Extracting all bits gives the same number.
|
|
EXPECT_EQ(ExtractBitRange(123, 31, 0), 123);
|
|
// Extracting 1 bit gives parity.
|
|
EXPECT_EQ(ExtractBitRange(123, 0, 0), 1);
|
|
EXPECT_EQ(ExtractBitRange(122, 0, 0), 0);
|
|
|
|
EXPECT_EQ(ExtractBitRange(0xF0, 7, 4), 0xF);
|
|
EXPECT_EQ(ExtractBitRange(0x42 << 2, 10, 2), 0x42);
|
|
}
|
|
|
|
} // namespace
|
|
} // namespace cpu_features
|