mirror of
https://github.com/google/cpu_features.git
synced 2025-04-28 15:33:37 +02:00

Visual C++ reported a number of warnings: ..\src\filesystem.c(27): warning C4996: '_open': This function or variable may be unsafe. Consider using _sopen_s instead. To disable deprecation, use _CRT_SECURE_NO_WARNINGS. See online help for details. ..\src\filesystem.c(34): warning C4267: 'function': conversion from 'size_t' to 'unsigned int', possible loss of data ..\src\string_view.c(25): warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data ..\src\string_view.c(41): warning C4244: 'return': conversion from '__int64' to 'int', possible loss of data ..\src\utils\list_cpu_features.c(151): warning C4090: 'function': different 'const' qualifiers ..\src\cpuinfo_x86.c(67): warning C4244: 'return': conversion from 'unsigned __int64' to 'uint32_t', possible loss of data ..\test\filesystem_for_testing.cc(48): warning C4267: 'return': conversion from 'size_t' to 'int', possible loss of data ..\test\filesystem_for_testing.cc(57): warning C4267: 'argument': conversion from 'size_t' to 'int', possible loss of data ..\test\bit_utils_test.cc(26): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data ..\test\bit_utils_test.cc(32): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data ..\test\bit_utils_test.cc(37): warning C4267: 'argument': conversion from 'size_t' to 'uint32_t', possible loss of data Most of them, with the exception of _open() -> _sopen_s() are about questionable implicit casts. Fixing the types and adding explicit casts to explicitly mark the intention (and silence the warnings in the process)
62 lines
1.7 KiB
C++
62 lines
1.7 KiB
C++
// Copyright 2017 Google Inc.
|
|
//
|
|
// Licensed under the Apache License, Version 2.0 (the "License");
|
|
// you may not use this file except in compliance with the License.
|
|
// You may obtain a copy of the License at
|
|
//
|
|
// http://www.apache.org/licenses/LICENSE-2.0
|
|
//
|
|
// Unless required by applicable law or agreed to in writing, software
|
|
// distributed under the License is distributed on an "AS IS" BASIS,
|
|
// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
|
|
// See the License for the specific language governing permissions and
|
|
// limitations under the License.
|
|
|
|
// Implements a fake filesystem, useful for tests.
|
|
#ifndef CPU_FEATURES_TEST_FILESYSTEM_FOR_TESTING_H_
|
|
#define CPU_FEATURES_TEST_FILESYSTEM_FOR_TESTING_H_
|
|
|
|
#include <memory>
|
|
#include <string>
|
|
#include <unordered_map>
|
|
|
|
#include "internal/filesystem.h"
|
|
|
|
namespace cpu_features {
|
|
|
|
class FakeFile {
|
|
public:
|
|
explicit FakeFile(int file_descriptor, const char* content);
|
|
~FakeFile();
|
|
|
|
void Open();
|
|
void Close();
|
|
int Read(int fd, void* buf, size_t count);
|
|
|
|
int GetFileDescriptor() const { return file_descriptor_; }
|
|
|
|
private:
|
|
const int file_descriptor_;
|
|
const std::string content_;
|
|
bool opened_ = false;
|
|
size_t head_index_ = 0;
|
|
};
|
|
|
|
class FakeFilesystem {
|
|
public:
|
|
void Reset();
|
|
FakeFile* CreateFile(const std::string& filename, const char* content);
|
|
FakeFile* FindFileOrDie(const int file_descriptor) const;
|
|
FakeFile* FindFileOrNull(const std::string& filename) const;
|
|
|
|
private:
|
|
int next_file_descriptor_ = 0;
|
|
std::unordered_map<std::string, std::unique_ptr<FakeFile>> files_;
|
|
};
|
|
|
|
FakeFilesystem& GetEmptyFilesystem();
|
|
|
|
} // namespace cpu_features
|
|
|
|
#endif // CPU_FEATURES_TEST_FILESYSTEM_FOR_TESTING_H_
|