mirror of
https://review.coreboot.org/flashrom.git
synced 2025-07-01 14:11:15 +02:00
Use helper functions chip_{read,write}[bwl] to access flash chips
The semantic patch I used in r418 to make the original conversion to accessor functions was missing one isomorphism: a[b] <=> *(a+b) The semantic patcher Coccinelle was used to create this patch. Semantic patch follows: @@ typedef uint8_t; expression a; volatile uint8_t *b; @@ - b[a] + *(b + a) @@ expression a; volatile uint8_t *b; @@ - *(b) = (a); + chip_writeb(a, b); @@ volatile uint8_t *b; @@ - *(b) + chip_readb(b) @@ type T; T b; @@ ( chip_readb | chip_writeb ) (..., - (T) - (b) + b ) Corresponding to flashrom svn r498. Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net> Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
4
jedec.c
4
jedec.c
@ -331,8 +331,8 @@ int write_jedec(struct flashchip *flash, uint8_t *buf)
|
||||
erase_chip_jedec(flash);
|
||||
// dumb check if erase was successful.
|
||||
for (i = 0; i < total_size; i++) {
|
||||
if (bios[i] != (uint8_t) 0xff) {
|
||||
printf("ERASE FAILED @%d, val %02x!\n", i, bios[i]);
|
||||
if (chip_readb(bios + i) != (uint8_t) 0xff) {
|
||||
printf("ERASE FAILED @%d, val %02x!\n", i, chip_readb(bios + i));
|
||||
return -1;
|
||||
}
|
||||
}
|
||||
|
Reference in New Issue
Block a user