openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-03 06:53:18 +02:00
Code Issues Releases Wiki Activity

tree: Retype variable laptop_ok with bool

Browse Source 
Use the bool type instead of an integer for the variable `laptop_ok`,
since this represents its purpose much better.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: I5d9fc3516bc2d29f11b056e35b3e5e324ce93423
Reviewed-on: https://review.coreboot.org/c/flashrom/+/66891
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Felix Singer
2022-08-19 03:03:47 +02:00
committed by Anastasia Klimchuk
parent 279add4f3a
commit 05ac08f786
4 changed files with 8 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
board_enable.c
View File

@ -22,6 +22,7 @@
#include <strings.h> #include <strings.h>
#include <string.h> #include <string.h>
#include <stdbool.h>
#include <stdlib.h> #include <stdlib.h>
#include "flash.h" #include "flash.h"
#include "programmer.h" #include "programmer.h"
@ -2292,7 +2293,7 @@ static int p2_not_a_laptop(void)
static int p2_whitelist_laptop(void) static int p2_whitelist_laptop(void)
{ {
is_laptop = 1; is_laptop = 1;
laptop_ok = 1; laptop_ok = true;
msg_pdbg("Whitelisted laptop detected.\n"); msg_pdbg("Whitelisted laptop detected.\n");
return 0; return 0;
} }

8
chipset_enable.c
View File

@ -826,7 +826,7 @@ static int enable_flash_ich_spi(const struct programmer_cfg *cfg, struct pci_dev
/* Suppress unknown laptop warning if we booted from SPI. */ /* Suppress unknown laptop warning if we booted from SPI. */
if (boot_buses & BUS_SPI) if (boot_buses & BUS_SPI)
laptop_ok = 1; laptop_ok = true;
return 0; return 0;
} }
@ -971,7 +971,7 @@ static int enable_flash_pch100_or_c620(const struct programmer_cfg *cfg,
/* Suppress unknown laptop warning if we booted from SPI. */ /* Suppress unknown laptop warning if we booted from SPI. */
if (!ret && (boot_buses & BUS_SPI)) if (!ret && (boot_buses & BUS_SPI))
laptop_ok = 1; laptop_ok = true;
_freepci_ret: _freepci_ret:
pci_free_dev(spi_dev); pci_free_dev(spi_dev);
@ -1087,7 +1087,7 @@ static int enable_flash_silvermont(const struct programmer_cfg *cfg, struct pci_
/* Suppress unknown laptop warning if we booted from SPI. */ /* Suppress unknown laptop warning if we booted from SPI. */
if (boot_buses & BUS_SPI) if (boot_buses & BUS_SPI)
laptop_ok = 1; laptop_ok = true;
return 0; return 0;
} }
@ -1676,7 +1676,7 @@ static int enable_flash_mcp6x_7x(const struct programmer_cfg *cfg, struct pci_de
/* Suppress unknown laptop warning if we booted from SPI. */ /* Suppress unknown laptop warning if we booted from SPI. */
if (!ret && want_spi) if (!ret && want_spi)
laptop_ok = 1; laptop_ok = true;
return ret; return ret;
} }

2
include/programmer.h
View File

@ -265,7 +265,7 @@ extern int superio_count;
#if CONFIG_INTERNAL == 1 #if CONFIG_INTERNAL == 1
extern int is_laptop; extern int is_laptop;
extern int laptop_ok; extern bool laptop_ok;
extern bool force_boardenable; extern bool force_boardenable;
extern bool force_boardmismatch; extern bool force_boardmismatch;
void probe_superio(void); void probe_superio(void);

2
internal.c
View File

@ -28,7 +28,7 @@
#endif #endif
int is_laptop = 0; int is_laptop = 0;
int laptop_ok = 0; bool laptop_ok = false;
bool force_boardenable = false; bool force_boardenable = false;
bool force_boardmismatch = false; bool force_boardmismatch = false;