openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

dummyflasher: fix propagation of register_*_master() return values

Browse Source 
This patch checks return value of register_*_master()
so that in case of an error this error is not ignored anymore.

TEST=ninja test

Change-Id: I3a7eeb3cdd814db18b0717ae8b40ecadb4c32f7c
Signed-off-by: Alexander Goncharov <chat@joursoir.net>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/72430
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Alexander Goncharov 2023-01-24 14:43:12 +04:00 committed by Anastasia Klimchuk
parent eabd3bab1c
commit 06bcc26b1d
1 changed files with 7 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
dummyflasher.c
View File

@ -1345,6 +1345,7 @@ static int init_data(const struct programmer_cfg *cfg,
static int dummy_init(const struct programmer_cfg *cfg) static int dummy_init(const struct programmer_cfg *cfg)
{ {
int ret = 0;
struct stat image_stat; struct stat image_stat;
struct emu_data *data = calloc(1, sizeof(*data)); struct emu_data *data = calloc(1, sizeof(*data));
@ -1410,15 +1411,15 @@ dummy_init_out:
} }
if (dummy_buses_supported & BUS_PROG) if (dummy_buses_supported & BUS_PROG)
register_opaque_master(&opaque_master_dummyflasher, data); ret |= register_opaque_master(&opaque_master_dummyflasher, data);
if (dummy_buses_supported & BUS_NONSPI) if (dummy_buses_supported & BUS_NONSPI)
register_par_master(&par_master_dummyflasher, ret |= register_par_master(&par_master_dummyflasher,
dummy_buses_supported & BUS_NONSPI, dummy_buses_supported & BUS_NONSPI,
data); data);
if (dummy_buses_supported & BUS_SPI) if (dummy_buses_supported & BUS_SPI)
register_spi_master(&spi_master_dummyflasher, data); ret |= register_spi_master(&spi_master_dummyflasher, data);
return 0; return ret;
} }
const struct programmer_entry programmer_dummy = { const struct programmer_entry programmer_dummy = {