openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 22:21:16 +02:00
Code Issues Releases Wiki Activity

par_master: Fix propagation of register_par_master() return values

Browse Source 
This patch checks return value of register_par_master()
so that in case of an error this error is not ignored anymore.

BUG=b:185191942
TEST=builds and ninja test

Change-Id: I377afae41708c7433a56615e2f096bce9c5349f1
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/57192
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Anastasia Klimchuk
2021-08-27 15:47:46 +10:00
committed by Edward O'Callaghan
parent 31b283bd21
commit 099e378512
10 changed files with 10 additions and 28 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
atapromise.c
View File

@ -152,14 +152,13 @@ static int atapromise_init(void)
}
max_rom_decode.parallel = rom_size;
register_par_master(&par_master_atapromise, BUS_PARALLEL, NULL);
msg_pwarn("Do not use this device as a generic programmer. It will leave anything outside\n"
"the first %zu kB of the flash chip in an undefined state. It works fine for the\n"
"purpose of updating the firmware of this device (padding may necessary).\n",
rom_size / 1024);
return 0;
return register_par_master(&par_master_atapromise, BUS_PARALLEL, NULL);
}
const struct programmer_entry programmer_atapromise = {