openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 06:01:16 +02:00
Code Issues Releases Wiki Activity

Sometimes we want to read/write more than 4 bytes of chip content at once

Browse Source 
Add chip_{read,write}n to the external flasher infrastructure which
read/write n bytes at once.

Fix a few places where the code used memcpy/memcmp although that is
strictly impossible with external flashers.
Place a FIXME in the layout.c code because usage is not totally clear
and needs to be fixed to support external flashers.

As a nice side benefit, we get a noticeable speedup for builtin flash
reading which is now a memcpy() of the full flash area instead of a
series of single-byte reads.

Corresponding to flashrom svn r579.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Urja Rannikko <urjaman@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Carl-Daniel Hailfinger
2009-06-05 18:32:07 +00:00
parent ca8bfc6c22
commit 0bd2a2bdc1
7 changed files with 100 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
82802ab.c
View File

@ -27,6 +27,7 @@
*/
#include <string.h>
#include <stdlib.h>
#include "flash.h"
// I need that Berkeley bit-map printer
@ -172,7 +173,12 @@ int write_82802ab(struct flashchip *flash, uint8_t *buf)
int total_size = flash->total_size * 1024;
int page_size = flash->page_size;
chipaddr bios = flash->virtual_memory;
uint8_t *tmpbuf = malloc(page_size);
if (!tmpbuf) {
printf("Could not allocate memory!\n");
exit(1);
}
printf("Programming page: \n");
for (i = 0; i < total_size / page_size; i++) {
printf
@ -186,8 +192,8 @@ int write_82802ab(struct flashchip *flash, uint8_t *buf)
* or not erased and rewritten; their data is retained also in
* sudden power off situations
*/
if (!memcmp((void *)(buf + i * page_size),
(void *)(bios + i * page_size), page_size)) {
chip_readn(tmpbuf, bios + i * page_size, page_size);
if (!memcmp((void *)(buf + i * page_size), tmpbuf, page_size)) {
printf("SKIPPED\n");
continue;
}
@ -199,6 +205,7 @@ int write_82802ab(struct flashchip *flash, uint8_t *buf)
}
printf("\n");
protect_jedec(bios);
free(tmpbuf);
return 0;
}