openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

Kill all exit() calls in chipset_enable.c

Browse Source 
Corresponding to flashrom svn r1429.

Signed-off-by: Tadas Slotkus <devtadas@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Tadas Slotkus 2011-09-06 18:49:31 +00:00 committed by Uwe Hermann
parent 48446c86ff
commit 0e3f1cf778
1 changed files with 4 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
chipset_enable.c
View File

@ -343,10 +343,7 @@ static int enable_flash_ich_dc(struct pci_dev *dev, const char *name)
msg_perr("Error: fwh_idsel= specified, but no value given.\n"); msg_perr("Error: fwh_idsel= specified, but no value given.\n");
idsel_garbage_out: idsel_garbage_out:
free(idsel); free(idsel);
/* FIXME: Return failure here once internal_init() starts return ERROR_FATAL;
* to care about the return value of the chipset enable.
*/
exit(1);
} }
free(idsel); free(idsel);
@ -489,6 +486,8 @@ static int enable_flash_ich_dc_spi(struct pci_dev *dev, const char *name,
/* Enable Flash Writes */ /* Enable Flash Writes */
ret = enable_flash_ich_dc(dev, name); ret = enable_flash_ich_dc(dev, name);
if (ret == ERROR_FATAL)
return ret;
/* Get physical address of Root Complex Register Block */ /* Get physical address of Root Complex Register Block */
tmp = pci_read_long(dev, 0xf0) & 0xffffc000; tmp = pci_read_long(dev, 0xf0) & 0xffffc000;
@ -894,7 +893,7 @@ static int enable_flash_sb400(struct pci_dev *dev, const char *name)
if (!smbusdev) { if (!smbusdev) {
msg_perr("ERROR: SMBus device not found. Aborting.\n"); msg_perr("ERROR: SMBus device not found. Aborting.\n");
exit(1); return ERROR_FATAL;
} }
/* Enable some SMBus stuff. */ /* Enable some SMBus stuff. */