From 13e74d26eaf59b22576d21e9623dc30e91c02de0 Mon Sep 17 00:00:00 2001 From: Felix Singer Date: Fri, 19 Aug 2022 03:23:35 +0200 Subject: [PATCH] ich_descriptors.c: Retype variable `has_forbidden_opcode` with bool Use the bool type instead of an integer for the variable `has_forbidden_opcode`, since this represents its purpose much better. Signed-off-by: Felix Singer Change-Id: I6214956e377547b894fc76237832b6f7b2db41dd Reviewed-on: https://review.coreboot.org/c/flashrom/+/66899 Reviewed-by: Anastasia Klimchuk Tested-by: build bot (Jenkins) Reviewed-by: Angel Pons --- ich_descriptors.c | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/ich_descriptors.c b/ich_descriptors.c index 1cb75830f..b37ce6d51 100644 --- a/ich_descriptors.c +++ b/ich_descriptors.c @@ -31,6 +31,7 @@ #define UPPER_MAP_OFFSET (4096 - 256 - 4) #define getVTBA(flumap) (((flumap)->FLUMAP1 << 4) & 0x00000ff0) +#include #include #include #include "flash.h" /* for msg_* */ @@ -398,9 +399,9 @@ void prettyprint_ich_descriptor_component(enum ich_chipset cs, const struct ich_ msg_pdbg2("Dual Output Fast Read Support: %sabled\n", desc->component.modes.dual_output ? "en" : "dis"); - int has_forbidden_opcode = 0; + bool has_forbidden_opcode = false; if (desc->component.FLILL != 0) { - has_forbidden_opcode = 1; + has_forbidden_opcode = true; msg_pdbg2("Invalid instruction 0: 0x%02x\n", desc->component.invalid_instr0); msg_pdbg2("Invalid instruction 1: 0x%02x\n", @@ -412,7 +413,7 @@ void prettyprint_ich_descriptor_component(enum ich_chipset cs, const struct ich_ } if (has_flill1) { if (desc->component.FLILL1 != 0) { - has_forbidden_opcode = 1; + has_forbidden_opcode = true; msg_pdbg2("Invalid instruction 4: 0x%02x\n", desc->component.invalid_instr4); msg_pdbg2("Invalid instruction 5: 0x%02x\n",