From 1687854423c34aeeaece48bdd9a52a28d01584f0 Mon Sep 17 00:00:00 2001 From: Stefan Tauner Date: Sun, 13 Jul 2014 23:53:40 +0000 Subject: [PATCH] Improve messages on failed erases with default verbosity Without this... Erasing and writing flash chip... ERASE FAILED at 0x00001000! Expected=0xff, Read=0xb4, failed byte count from 0x00000000-0x0000ffff: 0xef09 ERASE FAILED! Reading current flash chip contents... done. Erase/write done. Verifying flash... VERIFIED. Even if there is not a long temporal pause, it is very confusing for the user to first see a failed erase, followed by a read, a done message and eventually the verification message. This patch inserts "Looking for another erase function." where there is just a silent pause above. Corresponding to flashrom svn r1827. Signed-off-by: Stefan Tauner Acked-by: Stefan Tauner --- flashrom.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/flashrom.c b/flashrom.c index 408c5551d..4f41bf49f 100644 --- a/flashrom.c +++ b/flashrom.c @@ -1463,9 +1463,9 @@ int erase_and_write_flash(struct flashctx *flash, uint8_t *oldcontents, uint8_t for (k = 0; k < NUM_ERASEFUNCTIONS; k++) { if (k != 0) - msg_cdbg("Looking for another erase function.\n"); + msg_cinfo("Looking for another erase function.\n"); if (!usable_erasefunctions) { - msg_cdbg("No usable erase functions left.\n"); + msg_cinfo("No usable erase functions left.\n"); break; } msg_cdbg("Trying erase function %i... ", k);