openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-06-30 21:52:36 +02:00
Code Issues Releases Wiki Activity

Print an error message on read errors and abort instead of proceeding anyway

Browse Source 
Improve error checking in file write, chip read and chip verify.
Refactor the read routines a bit to split reading from file writing.

Log for a failed read:
[...]
Found chip "Winbond W25x16" (2048 KB, SPI) at physical address
0xffe00000.
Reading flash... Invalid OPCODE 0x03
Read operation failed!
FAILED.

Corresponding to flashrom svn r1079.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Stephen Kou <stephen@hyarros.com>
This commit is contained in:
Carl-Daniel Hailfinger
2010-07-13 23:56:13 +00:00
parent 4d3e9ca733
commit 1748c5701f
3 changed files with 46 additions and 19 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
cli_classic.c
View File

@ -417,7 +417,7 @@ int cli_classic(int argc, char *argv[])
exit(1);
}
printf("Please note that forced reads most likely contain garbage.\n");
return read_flash(flashes[0], filename);
return read_flash_to_file(flashes[0], filename);
}
// FIXME: flash writes stay enabled!
programmer_shutdown();