openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-26 22:52:34 +02:00
Code Issues Releases Wiki Activity

CID1130006: Memory leaks in buspirate_spi_init()

Browse Source 
The one in the error case of register_shutdown() was discovered while
reviewing the other one found by Coverity and fixed by Stefan Reinauer.

Corresponding to flashrom svn r1778.

Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
This commit is contained in:
Stefan Reinauer 2014-04-26 16:12:45 +00:00 committed by Stefan Tauner
parent 907c3eb800
commit 1838591b68
1 changed files with 6 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
buspirate_spi.c
View File

@ -250,6 +250,7 @@ int buspirate_spi_init(void)
if (!bp_commbuf) { if (!bp_commbuf) {
bp_commbufsize = 0; bp_commbufsize = 0;
msg_perr("Out of memory!\n"); msg_perr("Out of memory!\n");
free(dev);
return ERROR_OOM; return ERROR_OOM;
} }
bp_commbufsize = DEFAULT_BUFSIZE; bp_commbufsize = DEFAULT_BUFSIZE;
@ -263,8 +264,12 @@ int buspirate_spi_init(void)
return ret; return ret;
} }
if (register_shutdown(buspirate_spi_shutdown, NULL)) if (register_shutdown(buspirate_spi_shutdown, NULL) != 0) {
bp_commbufsize = 0;
free(bp_commbuf);
bp_commbuf = NULL;
return 1; return 1;
}
/* This is the brute force version, but it should work. /* This is the brute force version, but it should work.
* It is likely to fail if a previous flashrom run was aborted during a write with the new SPI commands * It is likely to fail if a previous flashrom run was aborted during a write with the new SPI commands