openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

spi_master: Add default write_aai function to masters that have none

Browse Source 
write_aai is required to register a spi master, if it is not set in
spi_master struct then register_spi_master returns ERROR_FLASHROM_BUG.

Masters in this patch did not have it set in the struct, and
register_spi_master always returned an error for them. However return
value of register_spi_master was ignored, so this was hard to notice.

Next patch in the chain checks return value of register_spi_master.

BUG=b:185191942
TEST=builds and ninja test

Change-Id: I712e74e11244e1f0ab8d8e245fcd5207ce211219
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56102
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
Anastasia Klimchuk 2021-07-05 16:51:10 +10:00 committed by Edward O'Callaghan
parent e2c8ecf6e0
commit 19c6b2821d
2 changed files with 2 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

1
ene_lpc.c
View File

@ -511,6 +511,7 @@ static const struct spi_master spi_master_ene = {
.multicommand = default_spi_send_multicommand, .multicommand = default_spi_send_multicommand,
.read = default_spi_read, .read = default_spi_read,
.write_256 = default_spi_write_256, .write_256 = default_spi_write_256,
.write_aai = default_spi_write_aai,
}; };
static int check_params(void) static int check_params(void)

1
mec1308.c
View File

@ -404,6 +404,7 @@ static const struct spi_master spi_master_mec1308 = {
.multicommand = default_spi_send_multicommand, .multicommand = default_spi_send_multicommand,
.read = default_spi_read, .read = default_spi_read,
.write_256 = default_spi_write_256, .write_256 = default_spi_write_256,
.write_aai = default_spi_write_aai,
}; };
static int check_params(void) static int check_params(void)