openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

Remove temporary buffers from bitbanging

Browse Source 
This removes the need of allocating an extra buffer, but also removes
the possibility of having the data read back during the initial write
phase for debugging purposes.

Compile tested, no functional testing.

Corresponding to flashrom svn r1084.

Signed-off-by: Michael Karcher <flashrom@mkarcher.dialup.fu-berlin.de>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
Michael Karcher 2010-07-17 10:42:34 +00:00
parent 420cf6f633
commit 1a854fc98c
1 changed files with 5 additions and 38 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

43
bitbang_spi.c
View File

@ -85,50 +85,17 @@ uint8_t bitbang_spi_readwrite_byte(uint8_t val)
int bitbang_spi_send_command(unsigned int writecnt, unsigned int readcnt, int bitbang_spi_send_command(unsigned int writecnt, unsigned int readcnt,
const unsigned char *writearr, unsigned char *readarr) const unsigned char *writearr, unsigned char *readarr)
{ {
static unsigned char *bufout = NULL;
static unsigned char *bufin = NULL;
static int oldbufsize = 0;
int bufsize;
int i; int i;
/* Arbitrary size limitation here. We're only constrained by memory. */
if (writecnt > 65536 || readcnt > 65536)
return SPI_INVALID_LENGTH;
bufsize = max(writecnt + readcnt, 260);
/* Never shrink. realloc() calls are expensive. */
if (bufsize > oldbufsize) {
bufout = realloc(bufout, bufsize);
if (!bufout) {
msg_perr("Out of memory!\n");
if (bufin)
free(bufin);
exit(1);
}
bufin = realloc(bufout, bufsize);
if (!bufin) {
msg_perr("Out of memory!\n");
if (bufout)
free(bufout);
exit(1);
}
oldbufsize = bufsize;
}
memcpy(bufout, writearr, writecnt);
/* Shift out 0x00 while reading data. */
memset(bufout + writecnt, 0x00, readcnt);
/* Make sure any non-read data is 0xff. */
memset(bufin + writecnt, 0xff, readcnt);
bitbang_spi_set_cs(0); bitbang_spi_set_cs(0);
for (i = 0; i < readcnt + writecnt; i++) { for (i = 0; i < writecnt; i++)
bufin[i] = bitbang_spi_readwrite_byte(bufout[i]); bitbang_spi_readwrite_byte(writearr[i]);
} for (i = 0; i < readcnt; i++)
readarr[i] = bitbang_spi_readwrite_byte(0);
programmer_delay(bitbang_spi_half_period); programmer_delay(bitbang_spi_half_period);
bitbang_spi_set_cs(1); bitbang_spi_set_cs(1);
programmer_delay(bitbang_spi_half_period); programmer_delay(bitbang_spi_half_period);
memcpy(readarr, bufin + writecnt, readcnt);
return 0; return 0;
} }