1
0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 14:11:15 +02:00

Clean up a25.c, at25.c, spi25.c

- introduce spi_prettyprint_status_register_atmel_at25_wpen()
- use spi_prettyprint_status_register_bit() where possible
- generify spi_prettyprint_status_register_bp3210 and use it in at25.c too

Corresponding to flashrom svn r1560.

Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
This commit is contained in:
Stefan Tauner
2012-08-02 23:51:28 +00:00
parent cb30158fbf
commit 1ba08f6d41
4 changed files with 25 additions and 31 deletions

15
spi25.c
View File

@ -327,21 +327,24 @@ void spi_prettyprint_status_register_welwip(uint8_t status)
}
/* Prettyprint the status register. Common definitions. */
void spi_prettyprint_status_register_bp3210(uint8_t status, int bp)
void spi_prettyprint_status_register_bp(uint8_t status, int bp)
{
switch (bp) {
/* Fall through. */
case 4:
msg_cdbg("Chip status register: Block Protect 4 (BP4) "
"is %sset\n", (status & (1 << 5)) ? "" : "not ");
case 3:
msg_cdbg("Chip status register: Bit 5 / Block Protect 3 (BP3) "
msg_cdbg("Chip status register: Block Protect 3 (BP3) "
"is %sset\n", (status & (1 << 5)) ? "" : "not ");
case 2:
msg_cdbg("Chip status register: Bit 4 / Block Protect 2 (BP2) "
msg_cdbg("Chip status register: Block Protect 2 (BP2) "
"is %sset\n", (status & (1 << 4)) ? "" : "not ");
case 1:
msg_cdbg("Chip status register: Bit 3 / Block Protect 1 (BP1) "
msg_cdbg("Chip status register: Block Protect 1 (BP1) "
"is %sset\n", (status & (1 << 3)) ? "" : "not ");
case 0:
msg_cdbg("Chip status register: Bit 2 / Block Protect 0 (BP0) "
msg_cdbg("Chip status register: Block Protect 0 (BP0) "
"is %sset\n", (status & (1 << 2)) ? "" : "not ");
}
}
@ -355,7 +358,7 @@ void spi_prettyprint_status_register_bit(uint8_t status, int bit)
static void spi_prettyprint_status_register_common(uint8_t status)
{
spi_prettyprint_status_register_bp3210(status, 3);
spi_prettyprint_status_register_bp(status, 3);
spi_prettyprint_status_register_welwip(status);
}