openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 14:33:18 +02:00
Code Issues Releases Wiki Activity

internal: Fix board vendor and model memory leaks

Browse Source 
The board vendor and model are sometimes specified as arguments during
an internal flash, so make sure they are freed at the end of
initialization.

Change-Id: I9f43708f3b075896be67acec114bc6f390f8c6ca
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1230664, 1230665
Reviewed-on: https://review.coreboot.org/c/flashrom/+/34846
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
This commit is contained in:
Jacob Garber
2019-08-12 11:14:14 -06:00
committed by Nico Huber
parent 15f539c8c9
commit 1c091d1aeb
3 changed files with 34 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
board_enable.c
View File

@ -2516,7 +2516,7 @@ int selfcheck_board_enables(void)
* Parameters vendor and model will be overwritten. Returns 0 on success.
* Note: strtok modifies the original string, so we work on a copy and allocate memory for the results.
*/
int board_parse_parameter(const char *boardstring, const char **vendor, const char **model)
int board_parse_parameter(const char *boardstring, char **vendor, char **model)
{
/* strtok may modify the original string. */
char *tempstr = strdup(boardstring);