openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 06:23:18 +02:00
Code Issues Releases Wiki Activity

sb600spi: Cleanup spispeed and spireamode warnings

Browse Source 
These warnings are printed at error level so they are displayed with
every invocation of flashrom. This clutters the flashrom output in the
usual case. Move warnings to debug level, add newline and clean up text.

TEST=Deploy to guybrush, observe messages are only seen when --verbose
is enabled
BUG=None
BRANCH=None

Change-Id: Idf5e735b9e504c943bf93a428da64976d723eb2c
Signed-off-by: Rob Barnes <robbarnes@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/58529
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Raul Rangel <rrangel@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
This commit is contained in:
Rob Barnes
2021-10-21 14:48:08 -06:00
committed by Angel Pons
parent 36fa20d176
commit 211cec1d75
1 changed files with 3 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
sb600spi.c
View File

@ -458,8 +458,8 @@ static int handle_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t *
msg_pdbg("SPI read mode is %s (%i)\n", msg_pdbg("SPI read mode is %s (%i)\n",
spireadmodes[read_mode], read_mode); spireadmodes[read_mode], read_mode);
if (spireadmode_idx < 0) { if (spireadmode_idx < 0) {
msg_perr("Warning: spireadmode not set, " msg_pdbg("spireadmode is not set, "
"leaving spireadmode unchanged."); "leaving SPI read mode unchanged.\n");
} }
else if (set_mode(dev, spireadmode_idx, sb600_spibar) != 0) { else if (set_mode(dev, spireadmode_idx, sb600_spibar) != 0) {
return 1; return 1;
@ -501,7 +501,7 @@ static int handle_speed(struct pci_dev *dev, enum amd_chipset amd_gen, uint8_t *
} }
} }
if (spispeed_idx < 0) { if (spispeed_idx < 0) {
msg_perr("Warning: spispeed not set, leaving spispeed unchanged."); msg_pdbg("spispeed is not set, leaving SPI speed unchanged.\n");
return 0; return 0;
} }
return set_speed(dev, amd_gen, spispeed_idx, sb600_spibar); return set_speed(dev, amd_gen, spispeed_idx, sb600_spibar);