openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 15:12:36 +02:00
Code Issues Releases Wiki Activity

util/git-hooks: Check for Signed-off-by line

Browse Source 
Enforce the DCO. The logic comes from coreboot's commit-msg hook,
and I've added a pointer to flashrom's development guidelines.

Change-Id: Iea49a06c2d4824be073eff98c8aae1cbc5b145e4
Signed-off-by: David Hendricks <david.hendricks@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/35295
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Nico Huber <nico.h@gmx.de>
This commit is contained in:
David Hendricks 2019-09-08 13:59:42 -07:00 committed by David Hendricks
parent 7f15de164c
commit 28d081924e
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
util/git-hooks/commit-msg
View File

@ -28,6 +28,8 @@ unset GREP_OPTIONS
CHANGE_ID_AFTER="Bug|Depends-On|Issue|Test|Feature|Fixes|Fixed|Staging-ID" CHANGE_ID_AFTER="Bug|Depends-On|Issue|Test|Feature|Fixes|Fixed|Staging-ID"
MSG="$1" MSG="$1"
DEV_GUIDELINES_URL="https://www.flashrom.org/Development_Guidelines"
# Check for, and add if missing, a unique Change-Id # Check for, and add if missing, a unique Change-Id
# #
add_ChangeId() { add_ChangeId() {
@ -192,6 +194,14 @@ _gen_ChangeId() {
git hash-object -t commit --stdin git hash-object -t commit --stdin
} }
test_signoff() {
if ! grep -qi '^[[:space:]]*\+Signed-off-by:' "$MSG"; then
printf "\nError: No Signed-off-by line in the commit message.\n"
printf "See: ${DEV_GUIDELINES_URL}\n"
exit 1
fi
}
# Test for duplicate signoffs/acks # Test for duplicate signoffs/acks
test_duplicate_signoffs_acks() { test_duplicate_signoffs_acks() {
test "" = "$(grep -i '^(Signed-off-by|Acked-by): ' "$MSG" | test "" = "$(grep -i '^(Signed-off-by|Acked-by): ' "$MSG" |
@ -202,6 +212,7 @@ test_duplicate_signoffs_acks() {
} }
main() { main() {
test_signoff
test_duplicate_signoffs_acks test_duplicate_signoffs_acks
add_ChangeId add_ChangeId
} }