openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-11-04 07:00:39 +01:00
Code Issues Releases Wiki Activity

reduce DELAY_MINIMUM_SLEEP_US to 100 by default

Browse Source 
This makes flashrom sleep more eagerly rather than busy-waiting,
observing that most delays in flashrom are either less than 100
microseconds (barely enough time to get any work done, even on a fast
machine) or much more than 1 millisecond (very wasteful to busy-loop).
Since we believe most systems offer good timer resolution that should
provide sleep latency on the order of 100 microseconds, this is a
reasonable default.

For DOS, the default is set to 50ms because the best available timing
source on DOS only ticks at about 20 Hz.

Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Change-Id: I0f431d240c670446218b14811ef62a34e4c83da2
Reviewed-on: https://review.coreboot.org/c/flashrom/+/81608
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Peter Marheine
2024-04-02 12:33:28 +11:00
parent b2a35e1bd4
commit 2c573640f3
2 changed files with 3 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
meson_cross/i586_djgpp_dos.txt
View File

@@ -30,6 +30,8 @@ default_library = 'static'
[project options] [project options]
tests = 'disabled' tests = 'disabled'
ich_descriptors_tool = 'disabled' ich_descriptors_tool = 'disabled'
# DOS time resolution is only about 50ms
delay_minimum_sleep_us = 50000
[properties] [properties]
sys_root = '/usr/local/djgpp' sys_root = '/usr/local/djgpp'

2
meson_options.txt
View File

@@ -21,6 +21,6 @@ option('man-pages', type : 'feature', value : 'auto', description : 'build the m
option('documentation', type : 'feature', value : 'auto', description : 'build the html documentation') option('documentation', type : 'feature', value : 'auto', description : 'build the html documentation')
option('ni845x_search_path', type : 'string', value : 'C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C', option('ni845x_search_path', type : 'string', value : 'C:\Program Files (x86)\National Instruments\Ni-845x\MS Visual C',
description : 'Path to search for the proprietary ni845x library and header (32-bit Windows only)') description : 'Path to search for the proprietary ni845x library and header (32-bit Windows only)')
option('delay_minimum_sleep_us', type : 'integer', min : 0, value : 100000, option('delay_minimum_sleep_us', type : 'integer', min : 0, value : 100,
description : 'Minimum time in microseconds to suspend execution for (rather than polling) when a delay is required.' description : 'Minimum time in microseconds to suspend execution for (rather than polling) when a delay is required.'
+ ' Larger values may perform better on machines with low timer resolution, at the cost of increased power.') + ' Larger values may perform better on machines with low timer resolution, at the cost of increased power.')