openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 22:21:16 +02:00
Code Issues Releases Wiki Activity

Flashrom only checks for very few chips if the erase worked

Browse Source 
And even when it checks if the erase worked, the result of that check is
often ignored.

Convert all erase functions and actually check return codes
almost everywhere.
Check inside all erase_* routines if erase worked, not outside.
erase_sector_jedec and erase_block_jedec have changed prototypes to
enable erase checking.

Uwe successfully tested LPC on an CK804 box and SPI on some SB600 box.

Corresponding to flashrom svn r595.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Signed-off-by: Urja Rannikko <urjaman@gmail.com>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Carl-Daniel Hailfinger
2009-06-15 17:23:36 +00:00
parent 0845464499
commit 30f7cb2f3c
22 changed files with 345 additions and 113 deletions
Download Patch File Download Diff File Expand all files Collapse all files

17
sst28sf040.c
View File

@ -54,14 +54,20 @@ static void unprotect_28sf040(chipaddr bios)
tmp = chip_readb(bios + 0x041A);
}
static int erase_sector_28sf040(chipaddr bios, unsigned long address)
static int erase_sector_28sf040(struct flashchip *flash, unsigned long address, int sector_size)
{
chipaddr bios = flash->virtual_memory;
chip_writeb(AUTO_PG_ERASE1, bios);
chip_writeb(AUTO_PG_ERASE2, bios + address);
/* wait for Toggle bit ready */
toggle_ready_jedec(bios);
if (check_erased_range(flash, address, sector_size)) {
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
return 0;
}
@ -124,6 +130,10 @@ int erase_28sf040(struct flashchip *flash)
programmer_delay(10);
toggle_ready_jedec(bios);
if (check_erased_range(flash, 0, flash->total_size * 1024)) {
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
return 0;
}
@ -139,7 +149,10 @@ int write_28sf040(struct flashchip *flash, uint8_t *buf)
printf("Programming page: ");
for (i = 0; i < total_size / page_size; i++) {
/* erase the page before programming */
erase_sector_28sf040(bios, i * page_size);
if (erase_sector_28sf040(flash, i * page_size, page_size)) {
fprintf(stderr, "ERASE FAILED!\n");
return -1;
}
/* write to the sector */
printf("%04d at address: 0x%08x", i, i * page_size);