openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 06:01:16 +02:00
Code Issues Releases Wiki Activity

tests: Add layout tests for overlapping regions

Browse Source 
There are no tests for layout, it would be great to add some.

Also partially inspired by
commit 06a89d7139
and commit c9039fc279

BUG=b:193584590
TEST=ninja test

Change-Id: I7aa8dc0c9bc5a22fe5deea757eea1a151b969cea
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56324
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Anastasia Klimchuk
2021-07-15 10:04:39 +10:00
committed by Edward O'Callaghan
parent 80c3296499
commit 35e8bf64a7
4 changed files with 116 additions and 0 deletions
Download Patch File Download Diff File Expand all files Collapse all files

103
tests/layout.c Normal file
View File

@ -0,0 +1,103 @@
/*
* This file is part of the flashrom project.
*
* Copyright 2021 Google LLC
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
* the Free Software Foundation; version 2 of the License.
*
* This program is distributed in the hope that it will be useful,
* but WITHOUT ANY WARRANTY; without even the implied warranty of
* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
* GNU General Public License for more details.
*/
#include <include/test.h>
#include <stdio.h>
#include "layout.h"
#include "libflashrom.h"
void included_regions_dont_overlap_test_success(void **state)
{
(void) state; /* unused */
printf("Creating layout...\n");
struct flashrom_layout *layout;
assert_int_equal(0, flashrom_layout_new(&layout));
printf("done\n");
printf("Adding and including first region...\n");
assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region"));
assert_int_equal(0, flashrom_layout_include_region(layout, "first region"));
printf("done\n");
printf("Adding and including second (non-overlapping) region...\n");
assert_int_equal(0, flashrom_layout_add_region(layout, 0x00031001, 0x0023efc0, "second region"));
assert_int_equal(0, flashrom_layout_include_region(layout, "second region"));
printf("done\n");
printf("Asserting included regions do not overlap...\n");
assert_int_equal(0, included_regions_overlap(layout));
printf("done\n");
printf("Releasing layout...\n");
flashrom_layout_release(layout);
printf("done\n");
}
void included_regions_overlap_test_success(void **state)
{
(void) state; /* unused */
printf("Creating layout...\n");
struct flashrom_layout *layout;
assert_int_equal(0, flashrom_layout_new(&layout));
printf("done\n");
printf("Adding and including first region...\n");
assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region"));
assert_int_equal(0, flashrom_layout_include_region(layout, "first region"));
printf("done\n");
printf("Adding and including second (overlapping) region...\n");
assert_int_equal(0, flashrom_layout_add_region(layout, 0x00027100, 0x0023efc0, "second region"));
assert_int_equal(0, flashrom_layout_include_region(layout, "second region"));
printf("done\n");
printf("Asserting included regions overlap...\n");
assert_int_equal(1, included_regions_overlap(layout));
printf("done\n");
printf("Releasing layout...\n");
flashrom_layout_release(layout);
printf("done\n");
}
void region_not_included_overlap_test_success(void **state)
{
(void) state; /* unused */
printf("Creating layout...\n");
struct flashrom_layout *layout;
assert_int_equal(0, flashrom_layout_new(&layout));
printf("done\n");
printf("Adding and including first region...\n");
assert_int_equal(0, flashrom_layout_add_region(layout, 0x00021000, 0x00031000, "first region"));
assert_int_equal(0, flashrom_layout_include_region(layout, "first region"));
printf("done\n");
printf("Adding second (overlapping) region, not included...\n");
assert_int_equal(0, flashrom_layout_add_region(layout, 0x00027100, 0x0023efc0, "second region"));
printf("done\n");
printf("Asserting included regions do not overlap...\n");
assert_int_equal(0, included_regions_overlap(layout));
printf("done\n");
printf("Releasing layout...\n");
flashrom_layout_release(layout);
printf("done\n");
}

1
tests/meson.build
View File

@ -19,6 +19,7 @@ srcs = [
'flashrom.c',
'spi25.c',
'init_shutdown.c',
'layout.c',
]
mocks = [

7
tests/tests.c
View File

@ -236,5 +236,12 @@ int main(void)
};
ret |= cmocka_run_group_tests_name("init_shutdown.c tests", init_shutdown_tests, NULL, NULL);
const struct CMUnitTest layout_tests[] = {
cmocka_unit_test(included_regions_dont_overlap_test_success),
cmocka_unit_test(included_regions_overlap_test_success),
cmocka_unit_test(region_not_included_overlap_test_success),
};
ret |= cmocka_run_group_tests_name("layout.c tests", layout_tests, NULL, NULL);
return ret;
}

5
tests/tests.h
View File

@ -47,4 +47,9 @@ void dediprog_init_and_shutdown_test_success(void **state);
void ene_lpc_init_and_shutdown_test_success(void **state);
void linux_spi_init_and_shutdown_test_success(void **state);
/* layout.c */
void included_regions_dont_overlap_test_success(void **state);
void included_regions_overlap_test_success(void **state);
void region_not_included_overlap_test_success(void **state);
#endif /* TESTS_H */