openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 14:33:18 +02:00
Code Issues Releases Wiki Activity

Get rid of perror()

Browse Source 
It prints to stderr and that's not what we want necesserily;
using msg_*err gives us more control.

Corresponding to flashrom svn r1668.

Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
Stefan Tauner
2013-04-07 13:08:30 +00:00
parent 73dc0db725
commit 363fd7e827
3 changed files with 17 additions and 17 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
flashrom.c
View File

@ -29,6 +29,7 @@
#endif
#include <string.h>
#include <stdlib.h>
#include <errno.h>
#include <ctype.h>
#include <getopt.h>
#if HAVE_UTSNAME == 1
@ -1158,11 +1159,11 @@ int read_buf_from_file(unsigned char *buf, unsigned long size,
struct stat image_stat;
if ((image = fopen(filename, "rb")) == NULL) {
perror(filename);
msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno));
return 1;
}
if (fstat(fileno(image), &image_stat) != 0) {
perror(filename);
msg_gerr("Error: getting metadata of file \"%s\" failed: %s\n", filename, strerror(errno));
fclose(image);
return 1;
}
@ -1174,7 +1175,7 @@ int read_buf_from_file(unsigned char *buf, unsigned long size,
}
numbytes = fread(buf, 1, size, image);
if (fclose(image)) {
perror(filename);
msg_gerr("Error: closing file \"%s\" failed: %s\n", filename, strerror(errno));
return 1;
}
if (numbytes != size) {
@ -1196,7 +1197,7 @@ int write_buf_to_file(unsigned char *buf, unsigned long size,
return 1;
}
if ((image = fopen(filename, "wb")) == NULL) {
perror(filename);
msg_gerr("Error: opening file \"%s\" failed: %s\n", filename, strerror(errno));
return 1;
}