From 3f8d1b4f2b13eca9603c6f73b07631a7a98cc160 Mon Sep 17 00:00:00 2001 From: Anastasia Klimchuk Date: Fri, 12 Nov 2021 16:22:29 +1100 Subject: [PATCH] tests: Set up mock chip memory in consistent and predictable way This patch adds a macro MOCK_CHIP_CONTENT which represents a memory state of a mock chip. The macro is used to initialise mock chip memory at the beginning of a test (in setup_chip function). Previously mock chip memory was not reset between tests. For existing tests that did not matter, however new test for verify operation (added later in this chain) needs mock chip memory to be setup in a predictable way. BUG=b:181803212 TEST=ninja test Change-Id: I0d7623a601c207bfc62d54ab89d94cda56d85871 Signed-off-by: Anastasia Klimchuk Reviewed-on: https://review.coreboot.org/c/flashrom/+/59237 Tested-by: build bot (Jenkins) Reviewed-by: Felix Singer Reviewed-by: Edward O'Callaghan --- tests/chip.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tests/chip.c b/tests/chip.c index 5d646ebe0..fd7094cc7 100644 --- a/tests/chip.c +++ b/tests/chip.c @@ -23,6 +23,7 @@ #include "programmer.h" #define MOCK_CHIP_SIZE (8*MiB) +#define MOCK_CHIP_CONTENT 0xff static struct { unsigned int unlock_calls; /* how many times unlock function was called */ @@ -93,6 +94,7 @@ static void setup_chip(struct flashrom_flashctx *flashctx, struct flashrom_layou flashctx->chip = chip; g_chip_state.unlock_calls = 0; + memset(g_chip_state.buf, MOCK_CHIP_CONTENT, sizeof(g_chip_state.buf)); printf("Creating layout with one included region... "); assert_int_equal(0, flashrom_layout_new(layout));