openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 22:43:17 +02:00
Code Issues Releases Wiki Activity

drivers/: Make 'internal_delay' the default unless defined

Browse Source 
Drop the explicit need to specify the default 'internal_delay'
callback function pointer in the programmer_entry struct.
This is a reasonable default for every other driver in the
tree with only the two exceptions of ch341a_spi.c and serprog.c.

Thus this simplifies driver development.

Change-Id: I17460bc2c0aebcbb48c8dfa052b260991525cc49
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67391
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Thomas Heijligen <src@posteo.de>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Reviewed-by: Nikolai Artemiev <nartemiev@google.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Edward O'Callaghan
2022-09-07 10:47:45 +10:00
committed by Felix Singer
parent 3d7905178d
commit 4b503bee39
37 changed files with 6 additions and 42 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
flashrom.c
View File

@ -219,8 +219,12 @@ void programmer_unmap_flash_region(void *virt_addr, size_t len)
void programmer_delay(unsigned int usecs)
{
if (usecs > 0)
programmer->delay(usecs);
if (usecs > 0) {
if (programmer->delay)
programmer->delay(usecs);
else
internal_delay(usecs);
}
}
int read_memmapped(struct flashctx *flash, uint8_t *buf, unsigned int start,
@ -1419,10 +1423,6 @@ int selfcheck(void)
msg_gerr("Programmer %s does not have a valid init function!\n", p->name);
ret = 1;
}
if (p->delay == NULL) {
msg_gerr("Programmer %s does not have a valid delay function!\n", p->name);
ret = 1;
}
if (p->map_flash_region == NULL) {
msg_gerr("Programmer %s does not have a valid map_flash_region function!\n", p->name);
ret = 1;