openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 22:21:16 +02:00
Code Issues Releases Wiki Activity

Fix -Wsign-compare trouble

Browse Source 
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.

Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
This commit is contained in:
Nico Huber
2018-12-23 20:03:35 +01:00
parent ef78de4a21
commit 519be66fc5
32 changed files with 116 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
dmi.c
View File

@ -147,7 +147,7 @@ static char *dmi_string(const char *buf, uint8_t string_id, const char *limit)
static void dmi_chassis_type(uint8_t code)
{
int i;
unsigned int i;
code &= 0x7f; /* bits 6:0 are chassis type, 7th bit is the lock bit */
is_laptop = 2;
for (i = 0; i < ARRAY_SIZE(dmi_chassis_types); i++) {
@ -161,7 +161,7 @@ static void dmi_chassis_type(uint8_t code)
static void dmi_table(uint32_t base, uint16_t len, uint16_t num)
{
int i = 0, j = 0;
unsigned int i = 0, j = 0;
uint8_t *dmi_table_mem = physmap_ro("DMI Table", base, len);
if (dmi_table_mem == NULL) {
@ -346,7 +346,7 @@ static char *get_dmi_string(const char *string_name)
static int dmi_fill(void)
{
int i;
unsigned int i;
char *chassis_type;
msg_pdbg("Using External DMI decoder.\n");
@ -376,7 +376,7 @@ static int dmi_fill(void)
static int dmi_shutdown(void *data)
{
int i;
unsigned int i;
for (i = 0; i < ARRAY_SIZE(dmi_strings); i++) {
free(dmi_strings[i].value);
dmi_strings[i].value = NULL;
@ -406,7 +406,7 @@ void dmi_init(void)
}
has_dmi_support = 1;
int i;
unsigned int i;
for (i = 0; i < ARRAY_SIZE(dmi_strings); i++) {
msg_pdbg("DMI string %s: \"%s\"\n", dmi_strings[i].keyword,
(dmi_strings[i].value == NULL) ? "" : dmi_strings[i].value);
@ -463,7 +463,7 @@ static int dmi_compare(const char *value, const char *pattern)
int dmi_match(const char *pattern)
{
int i;
unsigned int i;
if (!has_dmi_support)
return 0;