openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 22:43:17 +02:00
Code Issues Releases Wiki Activity

Fix -Wsign-compare trouble

Browse Source 
Mostly by changing to `unsigned` types where applicable, sometimes
`signed` types, and casting as a last resort.

Change-Id: I08895543ffb7a48058bcf91ef6500ca113f2d305
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/30409
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Jacob Garber <jgarber1@ualberta.ca>
This commit is contained in:
Nico Huber
2018-12-23 20:03:35 +01:00
parent ef78de4a21
commit 519be66fc5
32 changed files with 116 additions and 107 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
sst_fwhub.c
View File

@ -21,7 +21,7 @@
#include "flash.h"
#include "chipdrivers.h"
static int check_sst_fwhub_block_lock(struct flashctx *flash, int offset)
static int check_sst_fwhub_block_lock(struct flashctx *flash, unsigned int offset)
{
chipaddr registers = flash->virtual_registers;
uint8_t blockstatus;
@ -47,7 +47,7 @@ static int check_sst_fwhub_block_lock(struct flashctx *flash, int offset)
return blockstatus & 0x1;
}
static int clear_sst_fwhub_block_lock(struct flashctx *flash, int offset)
static int clear_sst_fwhub_block_lock(struct flashctx *flash, unsigned int offset)
{
chipaddr registers = flash->virtual_registers;
uint8_t blockstatus;
@ -67,7 +67,7 @@ static int clear_sst_fwhub_block_lock(struct flashctx *flash, int offset)
int printlock_sst_fwhub(struct flashctx *flash)
{
int i;
unsigned int i;
for (i = 0; i < flash->chip->total_size * 1024; i += flash->chip->page_size)
check_sst_fwhub_block_lock(flash, i);
@ -77,7 +77,8 @@ int printlock_sst_fwhub(struct flashctx *flash)
int unlock_sst_fwhub(struct flashctx *flash)
{
int i, ret=0;
unsigned int i;
int ret = 0;
for (i = 0; i < flash->chip->total_size * 1024; i += flash->chip->page_size)
{