openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

dummyflasher.c: Inline data fetch for spi workers

Browse Source 
The spi callbacks do not need par logic to fetch the
data field. Instead of going though get_data_from_context()
just fetch 'data' directly out of mst.spi.

This leads us towards a path of removing dummy_buses_supported
from global state.

BUG=none
BRANCH=none
TEST=`./flashrom -r /tmp/fwupdater.apnSQQ -p dummy:emulate=VARIABLE_SIZE,image=test_update.sh.tmp.emu,size=8388608`

Change-Id: I63b8d8861df75f52f241f09614146990fdfe59ed
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/54906
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Sam McNally <sammc@google.com>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Edward O'Callaghan 2021-05-25 20:47:02 +10:00 committed by Edward O'Callaghan
parent e3707bbf49
commit 52c0275c70
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
dummyflasher.c
View File

@ -129,7 +129,7 @@ void dummy_unmap(void *virt_addr, size_t len)
static int dummy_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len) static int dummy_spi_write_256(struct flashctx *flash, const uint8_t *buf, unsigned int start, unsigned int len)
{ {
struct emu_data *emu_data = get_data_from_context(flash); struct emu_data *emu_data = flash->mst->spi.data;
return spi_write_chunked(flash, buf, start, len, return spi_write_chunked(flash, buf, start, len,
emu_data->spi_write_256_chunksize); emu_data->spi_write_256_chunksize);
} }
@ -570,7 +570,7 @@ static int dummy_spi_send_command(const struct flashctx *flash, unsigned int wri
unsigned char *readarr) unsigned char *readarr)
{ {
unsigned int i; unsigned int i;
struct emu_data *emu_data = get_data_from_context(flash); struct emu_data *emu_data = flash->mst->spi.data;
if (!emu_data) { if (!emu_data) {
msg_perr("No data in flash context!\n"); msg_perr("No data in flash context!\n");
return 1; return 1;