openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 15:12:36 +02:00
Code Issues Releases Wiki Activity

realtek_mst_i2c_spi: don't always fail init

Browse Source 
In some earlier refactoring the init function for this programmer was
broken such that it never succeeds, since the return value was never set
to a value other than a generic failure. Fix it to return success unless
there is a problem.

TEST=flashrom -p realtek_mst_i2c_spi:bus=n --flash-size now works
     when n is a bus that has a connected MST.

Change-Id: I0596014fc9b76b4d11de230f9f5c414c1321dff1
Signed-off-by: Peter Marheine <pmarheine@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56799
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Peter Marheine 2021-08-04 17:13:42 +10:00 committed by Edward O'Callaghan
parent e0ece4a4bb
commit 541f79df44
1 changed files with 1 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
realtek_mst_i2c_spi.c
View File

@ -445,7 +445,7 @@ static int realtek_mst_i2c_spi_shutdown(void *data)
static int get_params(int *reset, int *enter_isp)
{
char *reset_str = NULL, *isp_str = NULL;
int ret = SPI_GENERIC_ERROR;
int ret = 0;
reset_str = extract_programmer_param("reset-mcu");
if (reset_str) {