openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-04 15:25:17 +02:00
Code Issues Releases Wiki Activity

flashrom_tester: Add positive check to verify_fail_test

Browse Source 
In verify_fail_test test that verify works when expected, as well as
fails when expected. A verify_region_from_file function is added to
support this.

BUG=b:235916336
BRANCH=None
TEST=None

Change-Id: Ibbcc97086466b67cfab4f6c32140bb5f2c456beb
Signed-off-by: Evan Benn <evanbenn@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/71974
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Evan Benn
2023-01-16 16:16:42 +11:00
committed by Edward O'Callaghan
parent 72e62750c8
commit 5735529d62
4 changed files with 50 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
util/flashrom_tester/src/tests.rs
View File

@ -44,6 +44,7 @@ use std::io::BufRead;
use std::sync::atomic::AtomicBool;
const ELOG_FILE: &str = "/tmp/elog.file";
const FW_MAIN_B_PATH: &str = "/tmp/FW_MAIN_B.bin";
/// Iterate over tests, yielding only those tests with names matching filter_names.
///
@ -312,7 +313,16 @@ fn partial_lock_test(section: LayoutNames) -> impl Fn(&mut TestEnv) -> TestResul
/// Check that flashrom 'verify' will fail if the provided data does not match the chip data.
fn verify_fail_test(env: &mut TestEnv) -> TestResult {
// Comparing the flash contents to random data says they're not the same.
env.ensure_golden()?;
// Verify that verify is Ok when the data matches. We verify only a region
// and not the whole chip because coprocessors or firmware may have written
// some data in other regions.
env.cmd
.read_region_into_file(FW_MAIN_B_PATH.as_ref(), "FW_MAIN_B")?;
env.cmd
.verify_region_from_file(FW_MAIN_B_PATH.as_ref(), "FW_MAIN_B")?;
// Verify that verify is false when the data does not match
match env.verify(env.random_data_file()) {
Ok(_) => Err("Verification says flash is full of random data".into()),
Err(_) => Ok(()),