openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-11-04 07:00:39 +01:00
Code Issues Releases Wiki Activity

flashchips: Add Spansion 25FL256S......0

Browse Source 
The Spansion 25SFL256S supports 4BA through an extended address register,
a 4BA mode set by bit 7 of that register, or native 4BA instructions.
Enable the former only for now.

Unfortunately the S25SF256S uses another instruction to write the exten-
ded address register. So we add an override for the instruction byte.

Change-Id: I0a95a81dfe86434f049215ebd8477392391b9efc
Signed-off-by: Nico Huber <nico.h@gmx.de>
Tested-by: Michael Fuckner <michael@fuckner.net>
Reviewed-on: https://review.coreboot.org/25132
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
This commit is contained in:
Nico Huber
2018-03-13 18:01:05 +01:00
parent 3eb5a8c82c
commit 57dbd64b33
3 changed files with 47 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

3
flash.h
View File

@@ -232,6 +232,9 @@ struct flashchip {
uint16_t max; uint16_t max;
} voltage; } voltage;
enum write_granularity gran; enum write_granularity gran;
/* SPI specific options (TODO: Make it a union in case other bustypes get specific options.) */
uint8_t wrea_override; /**< override opcode for write extended address register */
}; };
struct flashrom_flashctx { struct flashrom_flashctx {

42
flashchips.c
View File

@@ -12515,6 +12515,48 @@ const struct flashchip flashchips[] = {
.voltage = {2700, 3600}, .voltage = {2700, 3600},
}, },
{
.vendor = "Spansion",
.name = "S25FL256S......0", /* hybrid: 32 (top or bottom) 4 kB sub-sectors + 64 kB sectors */
.bustype = BUS_SPI,
.manufacture_id = SPANSION_ID,
.model_id = SPANSION_S25FL256,
.total_size = 32768,
.page_size = 256,
/* OTP: 1024B total, 32B reserved; read 0x4B; write 0x42 */
.feature_bits = FEATURE_WRSR_WREN | FEATURE_OTP | FEATURE_4BA_EXT_ADDR,
.tested = TEST_OK_PREW,
.probe = probe_spi_rdid,
.probe_timing = TIMING_ZERO,
.block_erasers = {
{
/* This chip supports erasing of the 32 so-called "parameter sectors" with
* opcode 0x20. Trying to access an address outside these 4kB blocks does
* have no effect on the memory contents, but sets a flag in the SR.
.eraseblocks = {
{4 * 1024, 32},
{64 * 1024, 254} // inaccessible
},
.block_erase = spi_block_erase_20,
}, { */
.eraseblocks = { { 64 * 1024, 512} },
.block_erase = spi_block_erase_d8,
}, {
.eraseblocks = { { 32768 * 1024, 1} },
.block_erase = spi_block_erase_60,
}, {
.eraseblocks = { { 32768 * 1024, 1} },
.block_erase = spi_block_erase_c7,
}
},
.printlock = spi_prettyprint_status_register_bp2_ep_srwd, /* TODO: SR2 and many others */
.unlock = spi_disable_blockprotect_bp2_srwd, /* TODO: various other locks */
.write = spi_chip_write_256, /* Multi I/O supported */
.read = spi_chip_read, /* Fast read (0x0B) and multi I/O supported */
.voltage = {2700, 3600},
.wrea_override = 0x17,
},
{ {
.vendor = "SST", .vendor = "SST",
.name = "SST25LF020A", .name = "SST25LF020A",

3
spi25.c
View File

@@ -341,13 +341,14 @@ static int spi_simple_write_cmd(struct flashctx *const flash, const uint8_t op,
static int spi_write_extended_address_register(struct flashctx *const flash, const uint8_t regdata) static int spi_write_extended_address_register(struct flashctx *const flash, const uint8_t regdata)
{ {
const uint8_t op = flash->chip->wrea_override ? : JEDEC_WRITE_EXT_ADDR_REG;
struct spi_command cmds[] = { struct spi_command cmds[] = {
{ {
.writecnt = 1, .writecnt = 1,
.writearr = (const unsigned char[]){ JEDEC_WREN }, .writearr = (const unsigned char[]){ JEDEC_WREN },
}, { }, {
.writecnt = 2, .writecnt = 2,
.writearr = (const unsigned char[]){ JEDEC_WRITE_EXT_ADDR_REG, regdata }, .writearr = (const unsigned char[]){ op, regdata },
}, },
NULL_SPI_CMD, NULL_SPI_CMD,
}; };