openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

ni845x_spi: Fix signed - unsigned comparisons

Browse Source 
Change-Id: I48ef927aa28433fb0e3b3a1f3fb2e797095e53bd
Signed-off-by: Miklós Márton <martonmiklosqdev@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/56637
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
This commit is contained in:
Miklós Márton 2021-07-27 14:56:59 +02:00 committed by Anastasia Klimchuk
parent 42b6346571
commit 57f75bbbf4
1 changed files with 4 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
ni845x_spi.c
View File

@ -185,7 +185,7 @@ static int ni845x_spi_open(const char *serial, uInt32 *return_handle)
device_pid = pid; device_pid = pid;
if (!serial || strtol(serial, NULL, 16) == serial_as_number) if (!serial || strtoul(serial, NULL, 16) == serial_as_number)
break; break;
if (found_devices_count > 1) { if (found_devices_count > 1) {
@ -222,7 +222,7 @@ static int usb8452_spi_set_io_voltage(uint16_t requested_io_voltage_mV,
uint16_t *set_io_voltage_mV, uint16_t *set_io_voltage_mV,
enum voltage_coerce_mode coerce_mode) enum voltage_coerce_mode coerce_mode)
{ {
int i = 0; unsigned int i = 0;
uint8_t selected_voltage_100mV = 0; uint8_t selected_voltage_100mV = 0;
uint8_t requested_io_voltage_100mV = 0; uint8_t requested_io_voltage_100mV = 0;
@ -552,9 +552,9 @@ static int ni845x_spi_init(const struct programmer_cfg *cfg)
// read the cs parameter (which Chip select should we use) // read the cs parameter (which Chip select should we use)
CS_str = extract_programmer_param_str(cfg, "cs"); CS_str = extract_programmer_param_str(cfg, "cs");
if (CS_str) { if (CS_str) {
CS_number = CS_str[0] - '0'; CS_number = strtoul(CS_str, NULL, 10);
free(CS_str); free(CS_str);
if (strlen(CS_str) > 1 || CS_number < 0 || 7 < CS_number) { if (CS_number > 7) {
msg_perr("Only CS 0-7 supported\n"); msg_perr("Only CS 0-7 supported\n");
return 1; return 1;
} }