openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 07:23:43 +02:00
Code Issues Releases Wiki Activity

flashrom.c: Separate out default layout init

Browse Source 
get_default_layout() is undefined without a
init_default_layout() so separate out that logic
from probe_flash().

Change-Id: I8fd0af8fb1c32dc9f2b00cc39b518d2f4d98e3ac
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68296
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Edward O'Callaghan 2022-10-11 21:27:37 +11:00 committed by Felix Singer
parent 71c6502378
commit 5d3b95bbac
1 changed files with 13 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
flashrom.c
View File

@ -761,6 +761,17 @@ char *flashbuses_to_text(enum chipbustype bustype)
return ret; return ret;
} }
static int init_default_layout(struct flashctx *flash)
{
/* Fill default layout covering the whole chip. */
if (flashrom_layout_new(&flash->default_layout) ||
flashrom_layout_add_region(flash->default_layout,
0, flash->chip->total_size * 1024 - 1, "complete flash") ||
flashrom_layout_include_region(flash->default_layout, "complete flash"))
return -1;
return 0;
}
int probe_flash(struct registered_master *mst, int startchip, struct flashctx *flash, int force) int probe_flash(struct registered_master *mst, int startchip, struct flashctx *flash, int force)
{ {
const struct flashchip *chip; const struct flashchip *chip;
@ -849,11 +860,7 @@ notfound:
if (!flash->chip) if (!flash->chip)
return -1; return -1;
/* Fill default layout covering the whole chip. */ if (init_default_layout(flash) < 0)
if (flashrom_layout_new(&flash->default_layout) ||
flashrom_layout_add_region(flash->default_layout,
0, flash->chip->total_size * 1024 - 1, "complete flash") ||
flashrom_layout_include_region(flash->default_layout, "complete flash"))
return -1; return -1;
tmp = flashbuses_to_text(flash->chip->bustype); tmp = flashbuses_to_text(flash->chip->bustype);