openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-28 15:33:42 +02:00
Code Issues Releases Wiki Activity

tests/lifecycle: Run shutdown for init error paths

Browse Source 
`run_init_error_path` tests the scenario when init function of
a programmer fails. Init can fail at different phases and depending
on a specific test scenario it could be before or after shutdown
function has been registered.

If shutdown function has already been registered, it needs to run
because it cleans up the resources allocated during init. This patch
prevents memory leaks.

BUG=b:181803212
TEST=ninja test

Change-Id: I604edff18e35b7c044b73d3a8adfa8c800eddfd2
Signed-off-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/67198
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Anastasia Klimchuk 2022-08-30 12:45:56 +10:00
parent 549b3998e8
commit 5fbe87ce50
1 changed files with 11 additions and 0 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
tests/lifecycle.c
View File

@ -87,6 +87,17 @@ void run_init_error_path(void **state, const struct io_mock *io, const struct pr
assert_int_equal(error_code, flashrom_programmer_init(&flashprog, prog->name, param_dup));
printf("... init failed with error code %i as expected\n", error_code);
/*
* `flashrom_programmer_shutdown` runs only registered shutdown functions, which means
* if nothing has been registered then nothing runs.
* Since this is testing error path on initialisation and error can happen at different
* phases of init, we don't know whether shutdown function has already been registered
* or not yet. Running `flashrom_programmer_shutdown` covers both situations.
*/
printf("Running programmer shutdown in case anything got registered...\n");
assert_int_equal(0, flashrom_programmer_shutdown(flashprog));
printf("... completed\n");
free(param_dup);
io_mock_register(NULL);