openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-26 22:52:34 +02:00
Code Issues Releases Wiki Activity

serprog: ignore failures when setting serial port options

Browse Source 
There is no good reason to abort earlier just because some options did
not stick. This should improve compatibility without negative effects. If
communication is affected by the missing flag(s) then we abort later
anyway.

Corresponding to flashrom svn r1906.

Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Urja Rannikko <urjaman@gmail.com>
This commit is contained in:
Stefan Tauner 2016-01-04 03:05:06 +00:00
parent a4d60f3101
commit 631bb02135
1 changed files with 18 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

23
serial.c
View File

@ -209,12 +209,25 @@ int serialport_config(fdtype fd, unsigned int baud)
if (observed.c_cflag != wanted.c_cflag || if (observed.c_cflag != wanted.c_cflag ||
observed.c_lflag != wanted.c_lflag || observed.c_lflag != wanted.c_lflag ||
observed.c_iflag != wanted.c_iflag || observed.c_iflag != wanted.c_iflag ||
observed.c_oflag != wanted.c_oflag || observed.c_oflag != wanted.c_oflag) {
cfgetispeed(&observed) != cfgetispeed(&wanted)) { msg_pwarn("Some requested serial options did not stick, continuing anyway.\n");
msg_perr("%s: Some requested options did not stick.\n", __func__); msg_pdbg(" observed wanted\n"
return 1; "c_cflag: 0x%08lX 0x%08lX\n"
"c_lflag: 0x%08lX 0x%08lX\n"
"c_iflag: 0x%08lX 0x%08lX\n"
"c_oflag: 0x%08lX 0x%08lX\n",
(long)observed.c_cflag, (long)wanted.c_cflag,
(long)observed.c_lflag, (long)wanted.c_lflag,
(long)observed.c_iflag, (long)wanted.c_iflag,
(long)observed.c_oflag, (long)wanted.c_oflag
);
}
if (cfgetispeed(&observed) != cfgetispeed(&wanted) ||
cfgetospeed(&observed) != cfgetospeed(&wanted)) {
msg_pwarn("Could not set baud rates exactly.\n");
msg_pdbg("Actual baud flags are: ispeed: 0x%08lX, ospeed: 0x%08lX\n",
(long)cfgetispeed(&observed), (long)cfgetospeed(&observed));
} }
msg_pdbg("Baud rate is %d now.\n", entry->baud);
#endif #endif
return 0; return 0;
} }