openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-10-13 22:10:23 +02:00
Code Issues Releases Wiki Activity

libflashrom: Add set log level functionality

Browse Source 
Before this commit, any message from Flashrom would trigger
the user's callback. This could lead to additional delays
and slow down overall Flashrom performance.

This patch adds the ability to configure the log level for
messages from Flashrom. It sets the default log level to INFO

Testing: Both unit tests and CLI tools serve as libflashrom clients.
    All unit tests run successfully.

Change-Id: I095d48b8feb5fbc950a36eb17bed0d7cb8d9df64
Signed-off-by: Dmitry Zhadinets <dzhadinets@gmail.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/87047
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Reviewed-by: Peter Marheine <pmarheine@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Dmitry Zhadinets
2025-03-29 19:10:24 -04:00
committed by Anastasia Klimchuk
parent b1794138f0
commit 6571f263b5
5 changed files with 65 additions and 11 deletions
Download Patch File Download Diff File Expand all files Collapse all files

11
libflashrom.c
View File

@@ -3,6 +3,7 @@
*
* Copyright (C) 2012, 2016 secunet Security Networks AG
* (Written by Nico Huber <nico.huber@secunet.com> for secunet)
* Copyright (C) 2025 Dmitry Zhadinets <dzhadinets@gmail.com>
*
* This program is free software; you can redistribute it and/or modify
* it under the terms of the GNU General Public License as published by
@@ -33,6 +34,7 @@
static flashrom_log_callback *global_log_callback = NULL;
static flashrom_log_callback_v2 *global_log_callback_v2 = NULL;
static void *global_log_user_data = NULL;
static enum flashrom_log_level global_log_level = FLASHROM_MSG_INFO;
int flashrom_init(const int perform_selfcheck)
{
@@ -46,8 +48,11 @@ int flashrom_shutdown(void)
return 0; /* TODO: nothing to do? */
}
/* TODO: flashrom_set_loglevel()? do we need it?
For now, let the user decide in their callback. */
void flashrom_set_log_level(enum flashrom_log_level level)
{
global_log_level = level;
}
void flashrom_set_log_callback(flashrom_log_callback *const log_callback)
{
global_log_callback = log_callback;
@@ -98,7 +103,7 @@ void flashrom_set_log_callback_v2(flashrom_log_callback_v2 *const log_callback,
/** @private */
int print(const enum flashrom_log_level level, const char *const fmt, ...)
{
if (global_log_callback) {
if (global_log_callback && level <= global_log_level) {
int ret;
va_list args;
va_start(args, fmt);