From 6599e34d5dc84440d7cfdf002cb523d54b583087 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Thu, 30 Jun 2022 18:30:20 +1000 Subject: [PATCH] realtek_mst_i2c_spi.c: Clarify gpio pin 88 comment to be more exacting Avoid confusion from the comment. While technically a GPIO can do anything, like drive a LED. The GPIO pin 88 *is* meant to drive the WP line of the SPI flash, that is its purpose. Change-Id: If718d41a27931380e5f7ebdb75b9863da0c61559 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/65546 Reviewed-by: Peter Marheine Reviewed-by: Thomas Heijligen Tested-by: build bot (Jenkins) --- realtek_mst_i2c_spi.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/realtek_mst_i2c_spi.c b/realtek_mst_i2c_spi.c index f03c20a6f..8c9bae1ad 100644 --- a/realtek_mst_i2c_spi.c +++ b/realtek_mst_i2c_spi.c @@ -191,8 +191,7 @@ static int realtek_mst_i2c_spi_read_indexed_register(int fd, uint16_t address, u } -/* Toggle the GPIO pin 88, this could be routed to different controls like write - * protection or a led. */ +/* Toggle the GPIO pin 88, reserved for write protection pin of the external flash. */ static int realtek_mst_i2c_spi_toggle_gpio_88_strap(int fd, bool toggle) { int ret = 0;