openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 22:21:16 +02:00
Code Issues Releases Wiki Activity

layout: Factor out flash_region structure from romentry

Browse Source 
The romentry structure is the container ADT with some
annotated meta-data such as 'included' or 'file' however
the substantive substructure is a 'flash_region'. Therefore
factor this out.

That is to say, the link list node 'romentry' is obscured by the implementation details of its use-case of 'flash_region' that we
clear up here.

BUG=b:260440773
BRANCH=none
TEST=flashrom_tester

Change-Id: I768742b73db901df5b5208fcbcb8a324a06014c2
CoAuthored-by: Nikolai Artemiev <nartemiev@google.com>
Signed-off-by: Nikolai Artemiev <nartemiev@google.com>
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/69196
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
Reviewed-by: Anastasia Klimchuk <aklm@chromium.org>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Nikolai Artemiev
2022-12-07 11:16:06 +11:00
committed by Edward O'Callaghan
parent 77fe266307
commit 66655b7423
4 changed files with 52 additions and 34 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
cli_classic.c
View File

@ -388,8 +388,9 @@ static int read_buf_from_include_args(const struct flashrom_layout *const layout
while ((entry = layout_next_included(layout, entry))) {
if (!entry->file)
continue;
if (read_buf_from_file(buf + entry->start,
entry->end - entry->start + 1, entry->file))
const struct flash_region *region = &entry->region;
if (read_buf_from_file(buf + region->start,
region->end - region->start + 1, entry->file))
return 1;
}
return 0;
@ -414,8 +415,9 @@ static int write_buf_to_include_args(const struct flashrom_layout *const layout,
while ((entry = layout_next_included(layout, entry))) {
if (!entry->file)
continue;
if (write_buf_to_file(buf + entry->start,
entry->end - entry->start + 1, entry->file))
const struct flash_region *region = &entry->region;
if (write_buf_to_file(buf + region->start,
region->end - region->start + 1, entry->file))
return 1;
}