mirror of
https://review.coreboot.org/flashrom.git
synced 2025-07-01 22:21:16 +02:00
internal: Move laptop_ok into board_cfg
Due to how internal is structured around chipset_flash_enable() entry we need to prepare a crafted programmer_cfg that contains a board_enable substructure with data derived from the board_enable subsystem. While this is certainly not perfection, it does make clear the relationships between board_enable into chipset_flash_enable and subsequently the overall internal programmer initialisation in a RAII fashion at the type level over closure upon global state that is impossible to reason about. Also flip predicate in report_nonwl_laptop_detected() and return early with the trivial base-case. TEST=`$ sudo ./flashrom -p internal --flash-name`. Change-Id: I459215253845c2af73262943ce91a36464e9eb06 Signed-off-by: Edward O'Callaghan <quasisec@google.com> Reviewed-on: https://review.coreboot.org/c/flashrom/+/73456 Tested-by: build bot (Jenkins) <no-reply@coreboot.org> Reviewed-by: Sam McNally <sammc@google.com>
This commit is contained in:

committed by
Edward O'Callaghan

parent
3ed016f08f
commit
67b5526d5c
@ -2293,7 +2293,7 @@ static int p2_not_a_laptop(struct board_cfg *cfg)
|
||||
static int p2_whitelist_laptop(struct board_cfg *cfg)
|
||||
{
|
||||
cfg->is_laptop = 1;
|
||||
g_laptop_ok = true;
|
||||
cfg->laptop_ok = true;
|
||||
msg_pdbg("Whitelisted laptop detected.\n");
|
||||
return 0;
|
||||
}
|
||||
|
Reference in New Issue
Block a user