openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 06:01:16 +02:00
Code Issues Releases Wiki Activity

libflashrom: remove flashrom_supported_programmers

Browse Source 
const char **flashrom_supported_programmers(void) returns an array of
strings without returning the array size or making a NULL
termination. This can lead to undefined behavior when iterating over the
array.

Change-Id: I0157926a654e337c14d840dd398e5576471c304f
Signed-off-by: Thomas Heijligen <thomas.heijligen@secunet.de>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/55350
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Nico Huber <nico.h@gmx.de>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Thomas Heijligen
2021-06-09 11:50:17 +02:00
committed by Nico Huber
parent d3ee782e4b
commit 6aaa51f19a
3 changed files with 0 additions and 22 deletions
Download Patch File Download Diff File Expand all files Collapse all files

20
libflashrom.c
View File

@ -113,26 +113,6 @@ const char *flashrom_version_info(void)
return flashrom_version; return flashrom_version;
} }
/**
* @brief Returns list of supported programmers
* @return List of supported programmers, or NULL if an error occurred
*/
const char **flashrom_supported_programmers(void)
{
size_t p = 0;
const char **supported_programmers = malloc((programmer_table_size + 1) * sizeof(char*));
if (supported_programmers != NULL) {
for (; p < programmer_table_size; ++p) {
supported_programmers[p] = programmer_table[p]->name;
}
} else {
msg_gerr("Memory allocation error!\n");
}
return supported_programmers;
}
/** /**
* @brief Returns list of supported flash chips * @brief Returns list of supported flash chips
* @return List of supported flash chips, or NULL if an error occurred * @return List of supported flash chips, or NULL if an error occurred

1
libflashrom.h
View File

@ -76,7 +76,6 @@ struct flashrom_chipset_info {
const char *flashrom_version_info(void); const char *flashrom_version_info(void);
void flashrom_system_info(void); void flashrom_system_info(void);
const char **flashrom_supported_programmers(void);
struct flashrom_flashchip_info *flashrom_supported_flash_chips(void); struct flashrom_flashchip_info *flashrom_supported_flash_chips(void);
struct flashrom_board_info *flashrom_supported_boards(void); struct flashrom_board_info *flashrom_supported_boards(void);
struct flashrom_chipset_info *flashrom_supported_chipsets(void); struct flashrom_chipset_info *flashrom_supported_chipsets(void);

1
libflashrom.map
View File

@ -24,7 +24,6 @@ LIBFLASHROM_1.0 {
flashrom_programmer_shutdown; flashrom_programmer_shutdown;
flashrom_set_log_callback; flashrom_set_log_callback;
flashrom_shutdown; flashrom_shutdown;
flashrom_supported_programmers;
flashrom_system_info; flashrom_system_info;
flashrom_version_info; flashrom_version_info;
local: *; local: *;