openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

layout.c: Use calloc() to ensure a zeroed layout

Browse Source 
No need to malloc() and then do a DIY memset to zero of the
heap. Just use calloc(1, ..) to get a zeroed heap.

Change-Id: Id6cf2c4591aec0620f15d8a39495d2bff6597f96
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68279
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
This commit is contained in:
Edward O'Callaghan 2022-10-11 14:24:17 +11:00 committed by Felix Singer
parent 955c01f5c4
commit 71c6502378
1 changed files with 1 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
layout.c
View File

@ -355,14 +355,12 @@ const struct romentry *layout_next(
int flashrom_layout_new(struct flashrom_layout **const layout) int flashrom_layout_new(struct flashrom_layout **const layout)
{ {
*layout = malloc(sizeof(**layout)); *layout = calloc(1, sizeof(**layout));
if (!*layout) { if (!*layout) {
msg_gerr("Error creating layout: %s\n", strerror(errno)); msg_gerr("Error creating layout: %s\n", strerror(errno));
return 1; return 1;
} }
const struct flashrom_layout tmp = { 0 };
**layout = tmp;
return 0; return 0;
} }