openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-04 07:15:18 +02:00
Code Issues Releases Wiki Activity

flashrom_tester: Call crossystem with write protect argument

Browse Source 
crossystem uses flashrom to gather data on some platforms. To avoid
firmware lock deadlock, call crossystem before initialising libflashrom.
When querying hardware write protect status, provide an argument to
crossystem so that only that field is queried. This also avoids the
deadlock, and improves performance.

BUG=b:239496316
BRANCH=None
TEST=on trogdor(arm), grunt(amd), hatch(intel):
TEST=flashrom_tester --libflashrom /usr/sbin/flashrom host Coreboot_ELOG_sanity
TEST=flashrom_tester /usr/sbin/flashrom host Coreboot_ELOG_sanity

Change-Id: I7d94cfc6ccbfbec91f12151eb0004724ccfc4e00
Signed-off-by: Evan Benn <evanbenn@chromium.org>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/65962
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Edward O'Callaghan <quasisec@chromium.org>
This commit is contained in:
Evan Benn
2022-07-19 14:20:30 +10:00
committed by Edward O'Callaghan
parent 1d38651865
commit 7346cda9e9
3 changed files with 22 additions and 92 deletions
Download Patch File Download Diff File Expand all files Collapse all files

6
util/flashrom_tester/src/tests.rs
View File

@ -86,6 +86,7 @@ pub fn generic<'a, TN: Iterator<Item = &'a str>>(
output_format: OutputFormat,
test_names: Option<TN>,
terminate_flag: Option<&AtomicBool>,
crossystem: String,
) -> Result<(), Box<dyn std::error::Error>> {
utils::ac_power_warning();
@ -106,10 +107,7 @@ pub fn generic<'a, TN: Iterator<Item = &'a str>>(
}
}
info!(
"Record crossystem information.\n{}",
utils::collect_crosssystem()?
);
info!("Record crossystem information.\n{}", crossystem);
// Register tests to run:
let tests: &[&dyn TestCase] = &[