openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-27 23:22:37 +02:00
Code Issues Releases Wiki Activity

ichspi.c: Clean up get_ich_spi_mode_param()

Browse Source 
Instead of checking for the variable arg in multiple compound
statements, separate it out in its own branch and return 0 if arg is
NULL.

Signed-off-by: Felix Singer <felixsinger@posteo.net>
Change-Id: Id1038568ff25cf6f0895b26921cc4a0d7bcfabb7
Reviewed-on: https://review.coreboot.org/c/flashrom/+/65248
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Thomas Heijligen <src@posteo.de>
This commit is contained in:
Felix Singer 2022-06-20 10:01:08 +02:00 committed by Thomas Heijligen
parent 1b880756d4
commit 75b7455441
1 changed files with 7 additions and 5 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
ichspi.c
View File

@ -1875,20 +1875,22 @@ enum ich_spi_mode {
static int get_ich_spi_mode_param(enum ich_spi_mode *ich_spi_mode) static int get_ich_spi_mode_param(enum ich_spi_mode *ich_spi_mode)
{ {
char *const arg = extract_programmer_param_str("ich_spi_mode"); char *const arg = extract_programmer_param_str("ich_spi_mode");
if (arg && !strcmp(arg, "hwseq")) { if (!arg) {
return 0;
} else if (!strcmp(arg, "hwseq")) {
*ich_spi_mode = ich_hwseq; *ich_spi_mode = ich_hwseq;
msg_pspew("user selected hwseq\n"); msg_pspew("user selected hwseq\n");
} else if (arg && !strcmp(arg, "swseq")) { } else if (!strcmp(arg, "swseq")) {
*ich_spi_mode = ich_swseq; *ich_spi_mode = ich_swseq;
msg_pspew("user selected swseq\n"); msg_pspew("user selected swseq\n");
} else if (arg && !strcmp(arg, "auto")) { } else if (!strcmp(arg, "auto")) {
msg_pspew("user selected auto\n"); msg_pspew("user selected auto\n");
*ich_spi_mode = ich_auto; *ich_spi_mode = ich_auto;
} else if (arg && !strlen(arg)) { } else if (!strlen(arg)) {
msg_perr("Missing argument for ich_spi_mode.\n"); msg_perr("Missing argument for ich_spi_mode.\n");
free(arg); free(arg);
return ERROR_FATAL; return ERROR_FATAL;
} else if (arg) { } else {
msg_perr("Unknown argument for ich_spi_mode: %s\n", arg); msg_perr("Unknown argument for ich_spi_mode: %s\n", arg);
free(arg); free(arg);
return ERROR_FATAL; return ERROR_FATAL;