openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 06:01:16 +02:00
Code Issues Releases Wiki Activity

tree/: Rename 'internal_delay()' to 'default_delay()'

Browse Source 
The non-custom driver programmer delay implementation
'internal_delay()' is unrelated specifically to the
'internal' programmer. The delay implementation is
simply a platform-agnostic host delay implementation.
Therefore, rename to simply default_delay().

Change-Id: I5e04adf16812ceb1480992c92bca25ed80f8897a
Signed-off-by: Edward O'Callaghan <quasisec@google.com>
Reviewed-on: https://review.coreboot.org/c/flashrom/+/68855
Reviewed-by: Alexander Goncharov <chat@joursoir.net>
Reviewed-by: Felix Singer <felixsinger@posteo.net>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
This commit is contained in:
Edward O'Callaghan
2022-10-26 13:46:14 +11:00
committed by Edward O'Callaghan
parent d1212796ab
commit 76f28a3fc2
18 changed files with 46 additions and 46 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
flashrom.c
View File

@ -260,18 +260,18 @@ void programmer_delay(const struct flashctx *flash, unsigned int usecs)
return;
/**
* Drivers should either use internal_delay() directly or their
* Drivers should either use default_delay() directly or their
* own custom delay. Only core flashrom logic calls programmer_delay()
* which should always have a valid flash context. A NULL context
* more than likely indicates a layering violation or BUG however
* for now dispatch a internal_delay() as a safe default for the NULL
* for now dispatch a default_delay() as a safe default for the NULL
* base case.
*/
if (!flash) {
msg_perr("%s called with NULL flash context. "
"Please report a bug at flashrom@flashrom.org\n",
__func__);
return internal_delay(usecs);
return default_delay(usecs);
}
if (flash->mst->buses_supported & BUS_SPI) {
@ -282,7 +282,7 @@ void programmer_delay(const struct flashctx *flash, unsigned int usecs)
return flash->mst->par.delay(flash, usecs);
}
return internal_delay(usecs);
return default_delay(usecs);
}
int read_memmapped(struct flashctx *flash, uint8_t *buf, unsigned int start,