openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-04-26 22:52:34 +02:00
Code Issues Releases Wiki Activity

CID1130002: Logically dead code due to copy and paste error

Browse Source 
What we really want to do is check whether PCI_BASE_ADDRESS_2 is valid at this
point, and not PCI_BASE_ADDRESS_0.

Corresponding to flashrom svn r1776.

Signed-off-by: Stefan Reinauer <stefan.reinauer@coreboot.org>
Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
Acked-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at>
This commit is contained in:
Stefan Reinauer 2014-04-26 16:12:15 +00:00 committed by Stefan Tauner
parent b879287c42
commit 789ea5e9bb
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
satamv.c
View File

@ -138,7 +138,7 @@ int satamv_init(void)
pci_rmmio_writel(tmp, mv_bar + GPIO_PORT_CONTROL); pci_rmmio_writel(tmp, mv_bar + GPIO_PORT_CONTROL);
/* Get I/O BAR location. */ /* Get I/O BAR location. */
tmp = pcidev_readbar(dev, PCI_BASE_ADDRESS_2); addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_2);
if (!addr) if (!addr)
return 1; return 1;
@ -146,7 +146,7 @@ int satamv_init(void)
* FIXME: Check if the I/O BAR is actually reachable. * FIXME: Check if the I/O BAR is actually reachable.
* This is an arch specific check. * This is an arch specific check.
*/ */
mv_iobar = tmp & 0xffff; mv_iobar = addr & 0xffff;
msg_pspew("Activating I/O BAR at 0x%04x\n", mv_iobar); msg_pspew("Activating I/O BAR at 0x%04x\n", mv_iobar);
/* 512 kByte with two 8-bit latches, and /* 512 kByte with two 8-bit latches, and