From 7c976e34631ca4ee6345bd109a3d5ae32e9c7246 Mon Sep 17 00:00:00 2001 From: Edward O'Callaghan Date: Sat, 12 Nov 2022 12:00:24 +1100 Subject: [PATCH] flashrom.c: Drop redundant chip read validation in verify_range() The 'chip_safety_check()' already validates the chip structure within 'prepare_flash_access()' before all subsequent chip operations such as 'verify_range()' and therefore the chip structure is guaranteed to be valid in the domain of those operations. BUG=none BRANCH=none TEST=builds Change-Id: Ifc57dd89715115e03d013691352463a8b3c0dc52 Signed-off-by: Edward O'Callaghan Reviewed-on: https://review.coreboot.org/c/flashrom/+/69471 Reviewed-by: Felix Singer Reviewed-by: Anastasia Klimchuk Tested-by: build bot (Jenkins) --- flashrom.c | 5 ----- 1 file changed, 5 deletions(-) diff --git a/flashrom.c b/flashrom.c index 5483af374..51a6b6443 100644 --- a/flashrom.c +++ b/flashrom.c @@ -511,11 +511,6 @@ int verify_range(struct flashctx *flash, const uint8_t *cmpbuf, unsigned int sta return -1; } - if (!lookup_read_func_ptr(flash->chip)) { - msg_cerr("ERROR: flashrom has no read function for this flash chip.\n"); - return -1; - } - uint8_t *readbuf = malloc(len); if (!readbuf) { msg_gerr("Could not allocate memory!\n");