1
0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-01 14:11:15 +02:00

Various IT85* cleanups and fixes

Fix a few typos.
Change the EC memory region mapping name.
Drop unused function parameter.
Use mmio_writeb()/mmio_readb() to get reliable access to volatile memory
locations instead of plain pointer access which is optimized away by gcc.
Use own it85_* SPI high-level chip read/write functions instead of
relying on unrelated ICH functions.

Corresponding to flashrom svn r1279.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>

David writes:
I applied the patch against the Chromium OS branch and
successfully tested read and write operations on a Cr48.

Acked-by: David Hendricks <dhendrix@google.com>
This commit is contained in:
Carl-Daniel Hailfinger
2011-03-08 00:23:49 +00:00
parent d95355880a
commit 7f517a7103
3 changed files with 32 additions and 19 deletions

4
spi.c
View File

@ -58,8 +58,8 @@ const struct spi_programmer spi_programmer[] = {
{ /* SPI_CONTROLLER_IT85XX */
.command = it85xx_spi_send_command,
.multicommand = default_spi_send_multicommand,
.read = ich_spi_read,
.write_256 = ich_spi_write_256,
.read = it85_spi_read,
.write_256 = it85_spi_write_256,
},
{ /* SPI_CONTROLLER_IT87XX */