mirror of
https://review.coreboot.org/flashrom.git
synced 2025-07-01 14:11:15 +02:00
Automatically unmap physmap()s
Similarly to the previous PCI self-clean up patch this one allows to get rid of a huge number of programmer shutdown functions and makes introducing bugs harder. It adds a new function rphysmap() that takes care of unmapping at shutdown. Callers are changed where it makes sense. Corresponding to flashrom svn r1714. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
11
ogp_spi.c
11
ogp_spi.c
@ -97,12 +97,6 @@ static const struct bitbang_spi_master bitbang_spi_master_ogp = {
|
||||
.half_period = 0,
|
||||
};
|
||||
|
||||
static int ogp_spi_shutdown(void *data)
|
||||
{
|
||||
physunmap(ogp_spibar, 4096);
|
||||
return 0;
|
||||
}
|
||||
|
||||
int ogp_spi_init(void)
|
||||
{
|
||||
struct pci_dev *dev = NULL;
|
||||
@ -137,9 +131,8 @@ int ogp_spi_init(void)
|
||||
return 1;
|
||||
|
||||
io_base_addr = pcidev_readbar(dev, PCI_BASE_ADDRESS_0);
|
||||
ogp_spibar = physmap("OGP registers", io_base_addr, 4096);
|
||||
|
||||
if (register_shutdown(ogp_spi_shutdown, NULL))
|
||||
ogp_spibar = rphysmap("OGP registers", io_base_addr, 4096);
|
||||
if (ogp_spibar == ERROR_PTR)
|
||||
return 1;
|
||||
|
||||
if (bitbang_spi_init(&bitbang_spi_master_ogp))
|
||||
|
Reference in New Issue
Block a user