mirror of
https://review.coreboot.org/flashrom.git
synced 2025-07-02 06:23:18 +02:00
Automatically unmap physmap()s
Similarly to the previous PCI self-clean up patch this one allows to get rid of a huge number of programmer shutdown functions and makes introducing bugs harder. It adds a new function rphysmap() that takes care of unmapping at shutdown. Callers are changed where it makes sense. Corresponding to flashrom svn r1714. Signed-off-by: Stefan Tauner <stefan.tauner@alumni.tuwien.ac.at> Acked-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
This commit is contained in:
@ -326,8 +326,10 @@ int sb600_probe_spi(struct pci_dev *dev)
|
||||
return 0;
|
||||
|
||||
/* Physical memory has to be mapped at page (4k) boundaries. */
|
||||
sb600_spibar = physmap("SB600 SPI registers", tmp & 0xfffff000,
|
||||
0x1000);
|
||||
sb600_spibar = rphysmap("SB600 SPI registers", tmp & 0xfffff000, 0x1000);
|
||||
if (sb600_spibar == ERROR_PTR)
|
||||
return 1;
|
||||
|
||||
/* The low bits of the SPI base address are used as offset into
|
||||
* the mapped page.
|
||||
*/
|
||||
|
Reference in New Issue
Block a user