openwrt/flashrom
1
0
Fork 0
mirror of https://review.coreboot.org/flashrom.git synced 2025-07-02 06:23:18 +02:00
Code Issues Releases Wiki Activity

Remove unneeded #include statements completely

Browse Source 
Unistd.h was only used to get a definition of NULL in all files. Add our
own NULL #define and remove unistd.h from flash.h
stdio.h has no place in flash.h, it should be included only in files
which really need it.
Add #include statements in individual .c files where needed.

Replace a few printf with msg_* to eliminate the need for stdio.h.

Corresponding to flashrom svn r1021.

Signed-off-by: Carl-Daniel Hailfinger <c-d.hailfinger.devel.2006@gmx.net>
Acked-by: Uwe Hermann <uwe@hermann-uwe.de>
This commit is contained in:
Carl-Daniel Hailfinger
2010-05-30 22:24:40 +00:00
parent 4178760241
commit 831e8f4abb
25 changed files with 40 additions and 51 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
board_enable.c
View File

@ -25,7 +25,6 @@
*/
#include <string.h>
#include <fcntl.h>
#include "flash.h"
#if defined(__i386__) || defined(__x86_64__)
@ -107,8 +106,8 @@ static int fdc37b787_gpio50_raise(uint16_t port, const char * name)
OUTB(0x55, port); /* enter conf mode */
id = sio_read(port, 0x20);
if (id != 0x44) {
fprintf(stderr, "\nERROR: %s: FDC37B787: Wrong ID 0x%02X.\n",
name, id);
msg_perr("\nERROR: %s: FDC37B787: Wrong ID 0x%02X.\n",
name, id);
OUTB(0xAA, port); /* leave conf mode */
return -1;
}
@ -118,8 +117,8 @@ static int fdc37b787_gpio50_raise(uint16_t port, const char * name)
val = sio_read(port, 0xC8); /* GP50 */
if ((val & 0x1B) != 0x10) /* output, no invert, GPIO */
{
fprintf(stderr, "\nERROR: %s: GPIO50 mode 0x%02X unexpected.\n",
name, val);
msg_perr("\nERROR: %s: GPIO50 mode 0x%02X unexpected.\n",
name, val);
OUTB(0xAA, port);
return -1;
}